Remove flag -probe.kubernetes.interval and stop re-syncing Kubernetes data #3080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set up a "watch" on everything we need so there is no reason to poll repeatedly.
|
Can we think of any reason why one would want to poll? |
|
@bboreham ping I am wondering whether we should get rid of the flag and associated machinery altogether. |
rade
approved these changes
Feb 22, 2018
|
To clarify, it doesn't actually poll the Kubernetes server on that interval; the resync is an in-process operation. So yes, we can remove the flag and hard-code the zero parameter. |
bboreham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set up a "watch" on everything we need so there is no reason to
pollre-sync repeatedly.