Skip to content

Conversation

foot
Copy link
Contributor

@foot foot commented Feb 5, 2018

  • It should only be visible on the kubernetes contoller node-details
    panels.
  • This fixes a bug where we were showing it on all node-details if you
    were on the controller topology.

Fixes https://github.com/weaveworks/service-ui/issues/1887

- It should only be visible on the kubernetes contoller node-details
  panels.
- This fixes a bug where we were showing it on all node-details if you
  were on the controller topology.
@foot foot requested a review from fbarl February 5, 2018 10:47
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@foot foot merged commit 8ac4811 into master Feb 6, 2018
@foot foot deleted the only-show-image-status-on-controllers branch February 6, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants