show unconnected processes #3009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We prevented this because rendering them was expensive. It still is, but less so and actually works well, especially in table mode.
since they are now always linkable.
Connections have always been linkable, so this is dead code.
It's always set to render.FilterUnconnectedPseudo, so we can simply use that constant in the one function (RendererForTopology) that looked at that value.
bboreham
approved these changes
Jan 2, 2018
rade
added a commit
that referenced
this pull request
Jun 3, 2018
...when 'Hide Unconnected' is selected, which is the default. Here's the problem... The connectedness filter looks for `is_connected` marks in the Latest map of the nodes. The mark is added by ColorConnected, which is invoked by ProcessRenderer. That in turn is the base renderer for ProcessNameRenderer, which is what the process-by-name view renders. However, the process2Names mapping does not propagate any metadata, hence there are no `is_connected` marks on the result nodes. Consequently they are all filtered out. The problem was introduced in #3009, when I added the ability for users to chose whether to show or hide unconnected processes (previously unconnected processes were always hidden) - looks like I failed to check that the process-by-name view was working with the new filter. Oops. The fix is to move the ColorConnected call from ProcessRenderer to the higher-level renderers - ProcessWithContainerNameRenderer (which is what the 'Processes' view renders) and ProcessNameRenderer. This has the beneficial side effect of improving performance for other renderers which invoke ProcessRenderer, none of which need connectedness-coloring. Fixes #3205
lilic
pushed a commit
to lilic/scope
that referenced
this pull request
Jul 25, 2018
...when 'Hide Unconnected' is selected, which is the default. Here's the problem... The connectedness filter looks for `is_connected` marks in the Latest map of the nodes. The mark is added by ColorConnected, which is invoked by ProcessRenderer. That in turn is the base renderer for ProcessNameRenderer, which is what the process-by-name view renders. However, the process2Names mapping does not propagate any metadata, hence there are no `is_connected` marks on the result nodes. Consequently they are all filtered out. The problem was introduced in weaveworks#3009, when I added the ability for users to chose whether to show or hide unconnected processes (previously unconnected processes were always hidden) - looks like I failed to check that the process-by-name view was working with the new filter. Oops. The fix is to move the ColorConnected call from ProcessRenderer to the higher-level renderers - ProcessWithContainerNameRenderer (which is what the 'Processes' view renders) and ProcessNameRenderer. This has the beneficial side effect of improving performance for other renderers which invoke ProcessRenderer, none of which need connectedness-coloring. Fixes weaveworks#3205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #991.