Skip to content

Avoid null dereferences in ECS client #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2017
Merged

Avoid null dereferences in ECS client #2514

merged 1 commit into from
May 10, 2017

Conversation

2opremio
Copy link
Contributor

(Hopefully) fixes #2508

@2opremio 2opremio requested a review from ekimekim May 10, 2017 15:29
ekimekim
ekimekim approved these changes May 10, 2017
View reviewed changes
Copy link
Contributor

@ekimekim ekimekim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure all these cases are possible to happen, but there's very little harm in being defensive here, so LGTM.

@2opremio 2opremio merged commit 9d89e8b into master May 10, 2017
@2opremio 2opremio deleted the 2508-avoid-null-derreferences branch May 10, 2017 15:46
This was referenced May 10, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ekimekim ekimekim ekimekim approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECS Probe - SIGSEGV: segmentation violation
2 participants
@2opremio @ekimekim