Forward OS/Kernel version to checkpoint #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related #2070 |
2opremio
force-pushed
the
checkpoint-kernel-version
branch
from
3b91ca0 to
82a8361
Compare
Useful to prioritize ebpf testing Also: * Make treatment of kernel release and version consistent across Darwin/Linux
2opremio
force-pushed
the
checkpoint-kernel-version
branch
from
82a8361 to
06ff64d
Compare
|
We do something like this in weave-net too; would be good to use the same labels and perhaps even code. |
|
Yep, the kernel version label is the same as in
weaveworks/weave#2372
I am not sure about sharing the code with Weave Net. I am reusing the code
in the host reporter.
…On Dec 19, 2016 9:47 PM, "Matthias Radestock" ***@***.***> wrote:
We do something like this in weave-net too; would be good to use the same
labels and perhaps even code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACQOJA1eiuFVRqKsNUTiHzC6m3vib61Wks5rJu1ngaJpZM4LQup5>
.
|
ekimekim
approved these changes
Dec 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to prioritize ebpf testing
Also:
Unify extraction of kernel version/release across Linux/Darwin(Can't be done since OSX doesn't provide theUnamesyscall)cc @alban