Add label_minor to tooltips in connections table #1912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes label is not enough to distinguish between rows.
|
|
davkal
reviewed
Oct 18, 2016
| ID string `json:"id"` // ID of this element in the UI. Must be unique for a given ConnectionsSummary. | ||
| NodeID string `json:"nodeId"` // ID of a node in the topology. Optional, must be set if linkable is true. | ||
| Label string `json:"label"` | ||
| LabelMinor string `json:"label_minor,omitempty"` |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Apart from the snake case, LGTM |
|
We use camelCase everywhere except label_minor! I can change that in this PR too. Should be safe to have FE/BE out of sync during update. I think we interpret label_minor as optional everywhere. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes label is not enough to distinguish between rows.
Fixes #1844