Skip to content

Name our routes, so /metrics gives more sensible aggregations #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2016
Merged

Name our routes, so /metrics gives more sensible aggregations #1723

merged 1 commit into from
Jul 26, 2016

Conversation

paulbellamy
Copy link
Contributor

Previously was showing stuff like:

{route="api_pipe_pipe_8999861204239855606_probe"}   2
{route="api_pipe_pipe_2001043336351237495_check"}   1
{route="api_pipe_pipe_5613831799035630055"}

@paulbellamy paulbellamy mentioned this pull request Jul 26, 2016
Closed
jml
jml reviewed Jul 26, 2016
View reviewed changes
app/controls.go
router.Methods("GET").Path("/api/control/ws").
router.
Methods("GET").
Path("/api/control/ws").
HandlerFunc(requestContextDecorator(handleProbeWS(cr)))

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@jml
Copy link
Contributor

jml commented Jul 26, 2016

One question, otherwise LGTM.

@jml
Copy link
Contributor

jml commented Jul 26, 2016

LGTM.

@paulbellamy paulbellamy merged commit 683727e into master Jul 26, 2016
@paulbellamy paulbellamy deleted the name-routes branch July 26, 2016 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbellamy @jml