Adding a static report file mode. #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also happy to leave out the demo.json file, as it adds 2.8M to the image. |
paulbellamy
force-pushed
the
demo
branch
2 times, most recently
from
c1caae4 to
691ad04
Compare
| // Add adds a report to the collector's internal state. It implements Adder. | ||
| func (c StaticCollector) Add(context.Context, report.Report) error { return nil } | ||
|
|
||
| // WaitOn lets other conponents wait on a new report being received. It |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I don't have strong feelings about whether the JSON file should stay or go. Everything else looks good, modulo a couple of nitpick comments. Please merge after addressing them. |
|
Thanks, discussed offline that adding the json file is terrible, but all the other options are worse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "file" collector to service a static report from file, then adds a demo.json report to the dockerfile.
Can run it with:
scope launch --no-probe --weave=false --app.collector=file:///demo.json