If we don't get a path name from the router, make one up from the url. #1570
Conversation
|
|
||
| // MakeLabelValue converts a Gorilla mux path to a string suitable for use in | ||
| // a Prometheus label value. | ||
| func MakeLabelValue(path string) string { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Mostly looks good but I've got a couple of questions. Thanks! |
|
@jml you're comments prompted me to give this some more thought. Have added a comment explaining what I'm trying to achieve in ae39936. Would you mind sanity checking this? Also /cc @peterbourgon |
| // 3. The request doesn't match a mux route. Munge the Path in the same | ||
| // manner as (2). | ||
| // We do all this as we do not wish to emit high cardinality labels to | ||
| // prometheus. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Looks good to me. I very much appreciate the comment explaining the intent. Punting to @peterbourgon for approval. |
|
Merging w/o @peterbourgon as I'd like to deploy this today, along with the NATS stuff. |
To stop the monitoring showing "unamed_path" everywhere.