This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Change the log level in RemoveContainer to debug #812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #791, we refactored
RemoveContainer()
method of the containerd clientand added some warning logs. This resulted in unintended warning logs.
Run a new VM:
Delete a VM:
RemoveContainer() is called before a VM is created and after a VM is
deleted. This results in warning logs with container or task not found
for the basic operations even when nothing wrong happened. The warning
could be misleading. Move the
not found
logs in RemoveContainer() todebug level to avoid such confusion.
Maybe consider doing the same for all other
not found
errors in the runtime clients?