Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add runtime and network info in VM object #651

Merged
merged 4 commits into from
Aug 10, 2020

Conversation

darkowlzz
Copy link
Contributor

This updates the VM API to add container runtime and network plugin info in
status.

Containerd + CNI:

  "status": {
    "running": true,
    "runtime": {
      "id": "ignite-206534faa94aee0b",
      "name": "containerd"
    },
    "startTime": "2020-08-03T14:07:09Z",
    "network": {
      "plugin": "cni",
      "ipAddresses": [
        "10.61.0.4"
      ]
    },

Docker + Docker-bridge:

  "status": {
    "running": true,
    "runtime": {
      "id": "9a37789bd112c6683d0d7389fd2f4c55aa87971e6e11d4e1df09bb5fefaa9664",
      "name": "docker"
    },
    "startTime": "2020-08-03T14:08:23Z",
    "network": {
      "plugin": "docker-bridge",
      "ipAddresses": [
        "172.17.0.2"
      ]
    },

Adds custom conversion for v1alpha2 API in conversion.go.
Updates the test golden files to have the new status fields.

Update the VM API to add container runtime and network plugin info in
status.
@darkowlzz darkowlzz requested a review from twelho as a code owner August 3, 2020 14:56
@darkowlzz darkowlzz added api/v1alpha3 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Aug 3, 2020
@stealthybox stealthybox merged commit 14e515f into weaveworks:master Aug 10, 2020
@darkowlzz darkowlzz deleted the status-runtime-network branch August 10, 2020 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api/v1alpha3 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants