Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Shadow the bogus /etc/resolv.conf of centos:8 to fix wksctl #611

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Jun 4, 2020

The centos:8 image currently used as the base for weaveworks/ignite-centos:latest includes a bogus /etc/resolv.conf file (that normally gets shadowed by Docker):

$ docker save centos:8 | tar -xf - -O cbab9bd72bc8f39dfc72b687ab56cd464589268d2a468ea8104fee89e4ca8b84/layer.tar | tar xO etc/resolv.conf
# Generated by NetworkManager
nameserver 192.168.122.1

This gets picked up by Ignite as a custom resolver configuration, so it won't be replaced with the symlink to the in-kernel DHCP at /proc/net/pnp. Subsequently, this then breaks wksctl integration as the Footloose-managed VMs don't have proper resolving configured resulting in no internet access (this probably affects Firekube as well).

Fix this by copying a blank file over /etc/resolv.conf during build.

Signed-off-by: Dennis Marttinen <dennis@weave.works>
@twelho twelho added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 4, 2020
@chanwit
Copy link
Member

chanwit commented Jun 4, 2020

LGTM

@twelho twelho merged commit 1a561d1 into weaveworks:master Jun 4, 2020
@twelho twelho deleted the fix-centos-resolvconf branch June 4, 2020 08:54
@darkowlzz darkowlzz added the kind/enhancement Categorizes issue or PR as related to improving an existing feature. label Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants