This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Ignore docker source cleanup err when resource not found #588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the snapshot not found error seen in the CI when importing VM,
kernel images and running a VM for the first time. The issue was due to
a missing containerd snapshot key which was attempted to be cleaned up.
Since the snapshot key didn't exist, the cleanup returned
snapshot <key> does not exist: not found
error.The fix checks if the error is a containerd "not found" error and
ignores it. Any other error during the cleanup is returned as before.
containerd cleanup function:
ignite/pkg/runtime/containerd/client.go
Lines 260 to 266 in fd8cd29
In case of docker, the cleanup removes a container.
Link to a CI build with debug logs: https://travis-ci.com/github/darkowlzz/ignite/builds/160924846#L529
It's possible that we are seeing this due to the containerd dependency update from 1.3.0 to 1.3.3, or maybe this issue always existed.