This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Workaround firecracker-go-sdk go.mod issue using new commit #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `v0.21.0` with `go mod tidy` using go versions 1.14.2, 1.12.17, and 1.12 produce a vendored dependency from firecracker that contains `CHANGELOG.md` and `version.go` from a commit with `v0.20.0` contents. We have not yet determined which commit the incorrect source is coming from. This should be opened up as an issue with github.com/golang/go with a dedicated reproduction. Problematic: ```shell go mod edit -require github.com/firecracker-microvm/firecracker-go-sdk@v0.21.0 go mod tidy ``` Commands run to produce this workaround: ```shell go mod edit -require github.com/firecracker-microvm/firecracker-go-sdk@e6eaff8 make tidy-in-docker # go mod tidy # go mod vendor # ... etc ``` cc @darkowlzz
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
v0.21.0withgo mod tidyusing go versions 1.14.2, 1.12.17, and 1.12produce a vendored dependency from firecracker that contains
CHANGELOG.mdand
version.gofrom a commit withv0.20.0contents.We have not yet determined which commit the incorrect source is coming from.
This should be opened up as an issue with github.com/golang/go with a
dedicated reproduction.
Problematic:
Commands run to produce this workaround:
cc @darkowlzz