Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Fix image import with runtime docker #564

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Fix image import with runtime docker #564

merged 1 commit into from
Mar 23, 2020

Conversation

darkowlzz
Copy link
Contributor

Importing image with runtime docker fails because the ReadCloser is
closed too early.

# ignite image import hello-world:latest --runtime=docker
INFO[0000] docker image "hello-world:latest" not found locally, pulling...
FATA[0006] http: read on closed response body

Defer DeferErr to avoid closing the ReadCloser early.

Adds an e2e test to ensure image import works with docker runtime.

@darkowlzz
Fix image import with runtime docker
52056d3 
Importing image with runtime docker fails because the ReadCloser is
closed too early.

```
FATA[0006] http: read on closed response body
```

Defer DeferErr to avoid closing the ReadCloser early.
@darkowlzz darkowlzz requested a review from twelho as a code owner March 22, 2020 18:10
@stealthybox stealthybox merged commit 159d172 into weaveworks:master Mar 23, 2020
@darkowlzz darkowlzz mentioned this pull request May 31, 2020
Closed
@luxas luxas added this to the v0.7.0 milestone Jun 2, 2020
@Khalian Khalian mentioned this pull request Aug 24, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@twelho twelho Awaiting requested review from twelho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@darkowlzz @stealthybox @luxas