This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
skip root requirement for ignite version #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
chanwit
force-pushed
the
check_root_only_when_needed
branch
from
515fcb6
to
ec2f8f8
Compare
|
kindly ping @stealthybox @dlespiau PTAL if this solves your problem. |
stealthybox
approved these changes
Sep 9, 2019
|
I did try this out locally. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root user should not be a requirement when doing
ignite run.How I did:
Use a simple check for
cmd.Name()to see if it isversion, then skip the root check.To verify:
run
ignite versionwithoutsudo.This PR fixes #406.
Signed-off-by: Chanwit Kaewkasi chanwit@gmail.com