Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Improve vulnerability scanning of Docker image #239

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

DieterReuter
Copy link
Contributor

Currently, the Alpine package list will be removed. This "optimization" saves less then 100 kBytes,
but without the package database file /lib/apk/db/installed it gets really harder to scan
this Docker Image for software vulnerabilities.

Therefore I'd like to strongly propose to remove this "optimization" step and keep the Alpine
package database file.

Signed-off-by: Dieter Reuter dieter.reuter@me.com

Currently, the Alpine package list will be removed. This "optimization" saves less then 100 kBytes,
but without the package database file `/lib/apk/db/installed` it gets really harder to scan
this Docker Image for software vulnerabilities.

Therefore I'd like to strongly propose to remove this "optimization" step and keep the Alpine
package database file.

Signed-off-by: Dieter Reuter <dieter.reuter@me.com>
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair call @DieterReuter and thanks for this PR!

LGTM 👍

@luxas luxas added this to the v0.5.0 milestone Jul 29, 2019
@luxas luxas self-assigned this Jul 29, 2019
@luxas luxas merged commit fed5235 into weaveworks:master Jul 29, 2019
@DieterReuter DieterReuter deleted the fix-package-list branch July 29, 2019 15:48
@luxas luxas added the kind/enhancement Categorizes issue or PR as related to improving an existing feature. label Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants