Initial reconciliation loop #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
force-pushed
the
reconciliation-loop
branch
5 times, most recently
from
0a5c949
to
c9dfd56
Compare
This deals with creation, update, removal of clusters from the AKS provider. Co-authored-by: Kevin McDermott <kevin@weave.works>
bigkevmcd
force-pushed
the
reconciliation-loop
branch
from
c9dfd56
to
b13d985
Compare
foot
reviewed
Oct 12, 2023
foot
reviewed
Oct 12, 2023
| } | ||
|
|
||
| existingClusters := []clustersv1alpha1.ResourceRef{} | ||
| inventoryResources := []clustersv1alpha1.ResourceRef{} |
There was a problem hiding this comment.
Should this be initialised to the existing resources?
There was a problem hiding this comment.
They get built up during the iteration.
There was a problem hiding this comment.
Ah har, at the moment we bail and return this initial empty inventory if we're adding a new cluster and encounter an error?
This might fall under the TODO list umbrella though very happy to merge and iterate here.
There was a problem hiding this comment.
Yeah, I don't think this is ready for release, but kinda hoping we can get smaller branches landing more frequently :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with creation, update, removal of clusters from the AKS provider.
It also rolls back the version of the controller-runtime from 0.16 as it was incompatible with some other dependencies.
Finally, it reverts the repo
main.goto be the controller main, as that's the common layout for controller.And I added an example AKS discovery CR.