Add AKS configuration to AutomatedClusterDiscovery CRD
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foot
reviewed
Oct 2, 2023
| @@ -42,6 +42,26 @@ spec: | |||
| type: | |||
| description: Type is the provider type | |||
| type: string | |||
| aks: | |||
There was a problem hiding this comment.
Ah! Do we have the changes to the https://github.com/weaveworks/cluster-reflector-controller/blob/main/api/v1alpha1/automatedclusterdiscovery_types.go too?
E.g. that file should be the source of truth, then we make generate and make manifests to generate this yaml file here etc etc.
There was a problem hiding this comment.
Thank you for pointing that out! I will change it now 🙂
sarataha
force-pushed
the
aks-configuration
branch
from
861511c
to
7ecb1e4
Compare
ranatrk
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: weaveworks/weave-gitops-enterprise#3391