Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Common Labels and Annotations to resources #18

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

bigkevmcd
Copy link
Collaborator

This adds functionality for adding a set of labels and annotations to the generated resources.

Setting commonLabels or commonAnnotations on the
AutomatedClusterDiscovery resource will result in labels and annotations being applied to the generated GitopsCluster and Secret resources.

@bigkevmcd bigkevmcd marked this pull request as ready for review October 30, 2023 12:05
This adds functionality for adding a set of labels and annotations to
the generated resources.

Setting commonLabels or commonAnnotations on the
AutomatedClusterDiscovery resource will result in labels and annotations
being applied to the generated GitopsCluster and Secret resources.
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

TIL comparable, which makes me think more or ordering. But in golang its == / !=. 👍

@bigkevmcd bigkevmcd merged commit 27e0965 into main Nov 8, 2023
3 checks passed
@bigkevmcd bigkevmcd deleted the add-labels-to-resources branch November 8, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants