Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds configMap RBAC #15

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Adds configMap RBAC #15

merged 2 commits into from
Oct 26, 2023

Conversation

foot
Copy link
Collaborator

@foot foot commented Oct 26, 2023

So we can read the kube-system/extension-manager-config configmap w/ azure cluster identity.

@foot
Adds RBAC to read the azure cluster details configmap
4a04417 
- Gives permissions for controller SA to read the `extension-manager-configmap`
- Need just need to read a specific one in kube-system
@foot
Scoping RBAC down to namespaces doesn't work great
a2f818b 
- Gets stripped out at some point in the tooling
@foot foot requested a review from bigkevmcd October 26, 2023 10:33
bigkevmcd
bigkevmcd approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@foot foot merged commit 2e4ddbd into main Oct 26, 2023
3 checks passed
@foot foot deleted the configmap-rbac branch October 26, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkevmcd bigkevmcd bigkevmcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foot @bigkevmcd