Switch to CreateOrPatch for creation/updates of resources. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleted resources will be recreated.
foot
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Works great!
Tested
- creating
- deleting
- interval: 20s, let it run for a while, seems happy.
- change existing to bad subId: seems to be backing off nicely (no status changes yet ofc), if cluster is connected it leaves it alone
- start with bad id: cluster not present
- fix subId in both cases: recovers
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using
CreateOrPatchfor all resources, which means that deleted resources will be recreated.