constraints in copy-object, get-object; process put-object result #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operation by etag or modified date Implemented Mappable for PutObjectResult and added call to to-map at end of put-object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes two things:
Modify get-object and copy-object to support the matchingEtags, nonmatchingEtags, modifiedSince, and unmodifiedSince constriants (defined in AWS's GetObjectRequest and CopyObjectRequest).
Modify put-object and the (extend-protocol Mappable... form to support converting the PutObjectResult object to a map that gets returned from put-object.
Note there is a API breaking change in get-object: to take options, I had to replace the function overload that takes a version-id. I added version-id as an option, but this may break existing code that relies on being able to pass a naked version-id as the third parameter. If this is unacceptable, please suggest an alternative and I'll modify the PR.