Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust layout and margin on under dev badge for weather stories #2209

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

partly-igor
Copy link
Collaborator

@partly-igor partly-igor commented Jan 10, 2025

What does this PR do? 🛠️

This small PR adjusts the positioning of the under development badge that was added in #2208. It also a light border around the badge to lessen the visual effect of the gold on light blue.

What does the reviewer need to know? 🤔

I'll raise the discussion elsewhere on whether we need the badge (even as we remove the dates).

Screenshots (if appropriate): 📸

Desktop

Alignment of the badge on desktop

mobile-lg/tablet

Alignment of the badge on mobile-lg

mobile

Alignment of the badge on mobile

@sspj-does-weather
Copy link
Collaborator

After discussion IRL, we decided to remove the under dev icon. @eric-gade or @loganmcdonald-noaa , could you give this a quick review when you have a chance?

Copy link
Collaborator

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sspj-does-weather
Copy link
Collaborator

@partly-igor I'd like to make sure this goes into the release today, so I'll go ahead and merge it in a little bit. If you see this message and don't want it in, let me know!

@sspj-does-weather sspj-does-weather merged commit d166940 into main Jan 16, 2025
19 of 21 checks passed
@sspj-does-weather sspj-does-weather deleted the ik/nudge-weather-story-badge branch January 16, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants