Skip to content

Allow expressions in yield_expression #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2020
Merged

Allow expressions in yield_expression #233

merged 2 commits into from
Mar 23, 2020

Conversation

@lysnikolaou
Copy link
Member

Prior to this, assignments like x: tuple = 1, 2 were not accepted.

@gvanrossum
Copy link
Collaborator

Hm, isn't that intentional?

@lysnikolaou
Copy link
Member Author

Hm, isn't that intentional?

But x: tuple = 1, 2 is valid in 3.8.

@pablogsal
Copy link
Collaborator

pablogsal commented Mar 23, 2020 •
edited
Loading

I think this was done here:

python/cpython#11667 and python/cpython#13760

gvanrossum
gvanrossum approved these changes Mar 23, 2020
View reviewed changes
Copy link
Collaborator

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! I had forgotten about that.

Maybe yield_expression could be renamed to annotated_rhs or something? Because that's what it's for -- it's only used as the RHS of an annotated variable.

@lysnikolaou lysnikolaou merged commit 95addf3 into we-like-parsers:master Mar 23, 2020
@lysnikolaou lysnikolaou deleted the assignment-bug branch March 23, 2020 15:54
@lysnikolaou lysnikolaou mentioned this pull request Mar 23, 2020
Merged
lysnikolaou added a commit to lysnikolaou/pegen_experiments that referenced this pull request Mar 23, 2020
@lysnikolaou
Update pegen/parse.c after we-like-parsers#233
76a00b9
lysnikolaou added a commit that referenced this pull request Mar 23, 2020
@lysnikolaou
Update pegen/parse.c after #233 (#234)
143d71c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lysnikolaou @gvanrossum @pablogsal