Skip to content

Comments

Button Layout Optimization#4

Draft
chavanashutosh wants to merge 1 commit intomainfrom
ButtonLayoutOptimization
Draft

Button Layout Optimization#4
chavanashutosh wants to merge 1 commit intomainfrom
ButtonLayoutOptimization

Conversation

@chavanashutosh
Copy link

No description provided.

}
}

.py-1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use standard .py-px, see https://tailwindcss.com/docs/padding

padding-top: 0.45rem;
padding-bottom: 0.45rem;
}
.px-2 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tailwind padding classes shouldn't be redefined, they should be configured with https://tailwindcss.com/docs/theme

import { useClipboard } from '@vueuse/core'

// Import necessary components
import {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuxt auto-imports components

@@ -0,0 +1,126 @@
<script setup lang="ts">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see AppNavigation component

:as="as"
:as-child="asChild"
:class="cn(buttonVariants({ variant, size }), props.class)"
:style="{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't use inline styles

@@ -0,0 +1,34 @@
Feature: Button Component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to define features for components

@@ -0,0 +1,28 @@
<template>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for design layout, it is not used

</div>
</template>

<style scoped>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for style scoped

@razbakov razbakov marked this pull request as draft March 24, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants