Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bobby Kwong choose your own adventure #198

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bobbykwong
Copy link

I added the commits into a wrong repo previously. So i only have one commit in this pull request. Sorry about that
Deliverable Submission

Please describe your comfort and completeness levels before submitting.

Comfort Level (1-5): 3

Completeness Level (1-5): 3

How many hours did you spend on this assignment? 5?

What part did you spend the most time on? Creating the story

Does the assignment run without errors? There are errors in one part. But they only appear at random instances so I am unsure how to resolve them.

If the assignment has errors, what are they?
It is the part where the user is fighting with the orc. I am using math.random to do "damages". Sometimes there is error when the "dice" is rolled.
Describe one part of the code or choose one line you would improve upon.

What would you improve?
A lot of my stuff appears in the console.log, which is not realistic for somebody who is playing the game.

What did you think of this deliverable? Any other comments?
Good challenge. Makes me realise that I am not organising my structure well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant