Code update and refractor #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrors.
Added as date and as count in selectRaw() to ensure pluck() works correctly.
Kept groupBy(DB::raw('DATE(created_at)')) for accurate aggregation by days.
update composer json as well
…getRouteModel()) for better readability. Improved exception handling – the catch block is now outside of storePageView(), keeping concerns separate. Optimized conditions – unnecessary checks and redundant logic removed. Used Laravel’s Str::limit() instead of Str::substr() for better readability. Used header() method for IP & referer handling – avoids redundant ternary checks
…ar(), and getCustomRange() method update controller create route file update model for fillable and cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed DB::raw() from pluck() to avoid Query\Expression conversion
Extracted logic into helper methods (shouldTrack(), storePageView()...
Add methods to get data through Analytics facade
create getLast28Days(), getLast3Months(), getLast6Months(), getLastYear(), and getCustomRange() method update controller create route file update model for fillable and cast