Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serializationFormat slingxml with xml output for Sling-Initial-Content #26

Merged
merged 4 commits into from
Apr 3, 2020

Conversation

mrozati
Copy link
Contributor

@mrozati mrozati commented Feb 4, 2020

add serializationFormat slingxml which can be used for XML outputs for Sling Initial Content. This generates the XML file with the clientlib name.

Masoud Rozati added 3 commits February 4, 2020 21:36
…itial content instead of FileVault. This only changes the output file name and path to <clientlib name>.xml instead of <clientlib name>/.content.xml
Copy link
Member

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me in general.

i was not able to execute the build/unit tests on my windows machine with this PR:

processing clientlib: test.base.apps.serializationFormatXML
Write node configuration using serialization format: xml
write clientlib json file: undefined
internal/fs/utils.js:453
    throw err;
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be one of type string, Buffer, or URL. Received type undefined

probably a windows-specific problem?

@@ -1,5 +1,11 @@
# Changelog

## 1.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, the changelog is outdated, it does not include the latest changes from 1.4.4, 1.5.0 and post-1.5.0.
next version will be 1.6.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I committed my changed on top of master branch, but I just see now that there is also a develop branch, which is "behind" the master. looks that something is wrong here.

@stefanseifert
Copy link
Member

@ifahrentholz please review

@mbehzad
Copy link
Contributor

mbehzad commented Mar 10, 2020

@mrozati , re: failed unit-test
the new getXmlOutputFile method does not return the contentXml value (from clientlib.js:256)
and one of the indentations for the xml output (clientlib.j:205) has one space too much (compared to the test snapshot and other lines in the xml output (:209, :211)

@mrozati
Copy link
Contributor Author

mrozati commented Mar 10, 2020

thanks. I fixed them

@ifahrentholz
Copy link
Member

@stefanseifert: On my machine the tests ran without an issue.

@ifahrentholz ifahrentholz merged commit c05e576 into wcm-io-frontend:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants