Fix GPUError message persistence in device.popErrorScope() #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
device.popErrorScope()
method was returning empty or garbage error messages instead of the actual WebGPU error text. This was caused by theGPUError
class storing the error message as achar const *
pointer, which became invalid after the WebGPU callback returned.Problem
Root Cause
The
GPUError
class was storing the error message as achar const *
pointer:When the WebGPU callback completed, the underlying string memory could be deallocated, leaving the pointer pointing to invalid memory.
Solution
Changed
GPUError
to store the message as astd::string
to ensure proper string persistence:Changes Made
char const *
tostd::string
c_str()
for proper string conversionTesting
Added
ErrorScope.spec.ts
with tests that verify:The fix is fully backward compatible with no API changes required.
Fixes #212.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io
/usr/local/bin/node install.mjs
(dns block)https://storage.googleapis.com/chrome-for-testing-public/127.0.6533.88/linux64/chrome-linux64.zip
/usr/local/bin/node install.mjs
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.