Pass hook name into plugin run functions#1053
Open
itmecho wants to merge 2 commits intowbthomason:masterfrom
Open
Pass hook name into plugin run functions#1053itmecho wants to merge 2 commits intowbthomason:masterfrom
itmecho wants to merge 2 commits intowbthomason:masterfrom
Conversation
akinsho
reviewed
Sep 6, 2022
lua/packer/plugin_utils.lua
Outdated
| end | ||
|
|
||
| plugin_utils.post_install_hook = function(plugin, disp) | ||
| return run_hook(plugin, disp, 'post_install') |
Collaborator
There was a problem hiding this comment.
Rather than an ever expanding list of arguments, I think when you start to pass more and more args into a function it might be time to pass in a table instead, so you scale out the inputs more easily without worrying about naked args and positioning and nil-ness i.e.
I think this should be
return run_hook(plugin, disp, { hook_name = 'post_install' })
Author
There was a problem hiding this comment.
Not sure if it needs a default value as it's an internal function but I've left it as an empty string. Not sure what the best thing to set it to would be?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1050
This PR adds a third argument the plugin run function, allowing the user to easily run code only on install or update of a plugin.
It should be backwards compatible as existing functions that only accept 2 arguments will still work as before.