-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run docker build on PR #852
Conversation
Deployment previews on netlify for branch
|
Over in |
@m90 please check again |
I think the additional trigger is still needed. See the action definition for API as a reference |
can you elaborate @m90 ? |
Right now, only pushes to main will trigger a build at all:
Compare this with API which has an additional
I don't think the tags are needed for |
While this now correctly stopped pushing the image to the image registry, we still need to prevent all of the following steps (the ones creating a pull request in the deploy repo and sending out a mattermost notification about it) from running. This can be doing using a top-level if condition on a - name: Something that should not run for Pull Requests
if: github.event_name != 'pull_request'
# ... |
fb4f4b5
to
8b3411b
Compare
No description provided.