Skip to content

Add complaint link and redesign footer #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add complaint link and redesign footer #1012

wants to merge 8 commits into from

Conversation

dati18
Copy link
Contributor

@dati18 dati18 commented Jul 15, 2025

No description provided.

@github-actions GitHub Actions
Copy link

Deployment previews on netlify for branch refs/pull/1012/merge will be at the following locations (when build is done):

dati18 and others added 4 commits August 3, 2025 23:28
@dati18
Switch to static CSS breakpoint instead of JS
47091d6
@rosalieper @dati18
Add a form for users to report illegal content (#1008)
7c10b11 
* Add a form for users to report illegal content

* fix form design

* fix linting errors

* add complaint/ to the mock api

* Fix padding and clear form on submit ssucess

* fix lint error and padding

* form should reset only after submition

* fix linting
@dati18
add footer-padding of 56px
8ea4f62
@dati18
fix height bug
a293df6
@dati18
Copy link
Contributor Author

dati18 commented Aug 3, 2025 •
edited
Loading

I have to remove the logic behind "flexible breakpoints" and fallback to use static CSS breakpoint because it's annoying, waste of effort and totally fragile.
In Firefox it can work fine and the breakpoint is calculated at480px, but on Chrome it is 450px and weird behaviors occur. This is due to Firefox and Chrome calculate the widths of flex items, scrollbars, subpixel rounding, or default styles differently. In my code, the breakpoint is determined by JavaScript measuring the combined width of the two columns plus a fixed value (col1Width + col2Width + 176). This calculation can yield slightly different results in different browsers.
I prefer consistency, easy to maintain and easy to be reviewed code over over-engineering crap.

Sorry for reading my vent :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosalieper rosalieper rosalieper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dati18 @rosalieper