Skip to content

Add code linting using Laravel Pint #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

AndrewKostka
Copy link
Contributor

Bug: T394986

Copy link
Member

@outdooracorn outdooracorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through the changes this linting applies, I'm happy with most of them. I would vote to change a few things:

  1. headsDownCamelCase instead of snake_case for function names - this should remove a lot of changes
  2. keep function's opening brace ({) on the same line as the function definition
  3. keep a space around the string concatenation operator (.) - I think it makes it look less like a full stop and more like an operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants