-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore original Material Theme and remove dead packages. #8658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Packages removed:
- Material Theme
- Material Theme - Appbar
- Material Theme - White Panels
|
This is not how open source licenses such as the MIT license work. The work is still clearly licensed to you and I merely restored it to a publicly available state, which is also explicitly mentioned at the top of the readme. I do realized that I did not consider to add an additional I'm not interested in maintaining the package. I simply fixed broken user setups and made a to this date very popular theme for the Sublime Text text editor installable again. However, it does not appear that you are willing to maintain the package either and from the past experience, I'd rather not run into the same or a similar situation again when the current situation works and is one that our community is in control of. That said, I am very eager to know about the meaning and context behind the warning about "dangerous code and dependencies". I did have a quick look over the Python code in the package before reinstating it but did not notice anything relevant. I did not find anything in the repository's issues either and I wasn't able to inquire about it in the issue on the original repository where this was mentioned because it was locked. |
We know. But you could just contact us and fix it together instead of recreating a deleted repo and pointing the theme to a clone.
The warning is about dependencies and cloning the repo on a local machine, is not about using the bundled version. Now, seeing the reaction to our move (which i remind is a free open-source project and we own the rights to delete it any time) we restored the repository under our scope, so thi PR points to an unmaintained (but working it seems) package again, like since 2016. I want to remind that Material Theme for ST was deprecated back in 2016, and did't get any update of fix since then. Is not our fault is Package Control rely only on repository URLs and doesn't handle broken themes errors. It should just disable the theme and show the error is something is wrong with the package. Now, just merge the PR thanks. |
|
@jrappen done. |
I think we should keep going with the current fork for safety reasons as the original author made it more than clear he has no interest in further mainanance nor respecting end users expectaions of reliably working packages. |
Also add the name of the new-ish "material-theme" org that hosts the vsc package (and another mirror of the repo; see #8658 for details).
For the aforementioned reasons, I went ahead with merging #8659 in favor of this PR and will close it instead. As I mentioned there, should you be interested in updating the theme again, we can discuss changing the reference on Package Control's channel again. Of course, you're also always free to submit pull requests to our fork (that still has a commit history) since the project is Open Source, without having to worry about maintaining it. |
My package is the original Material Theme. Just restored it to remove the stolen copy published under SublimeText name.