Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring controllers logic in frontend #69

Merged
merged 11 commits into from
May 22, 2018
Merged

Refactoring controllers logic in frontend #69

merged 11 commits into from
May 22, 2018

Conversation

manuasir
Copy link
Contributor

Hi splunkers, this PR refactors view controllers in frontend. The main changes are the following:

  • Separate current services.js into two new modules:
    • API Service: Handles and manages all relating to interaction with Splunk backend API.
    • KVStore Servicee: Handles and manages all relating to KV Store database service.
  • Implement services as abstract classes
    • Service methods shouldn't be instantiated.
    • Use static in class methods.
  • Deleted unused dependencies in controllers.
  • Fetch third party libraries from CDN instead locally.

@manuasir manuasir added type/enhancement Enhancement issue frontend labels May 22, 2018
@manuasir manuasir added this to the v3.3 milestone May 22, 2018
@manuasir manuasir self-assigned this May 22, 2018
@manuasir manuasir merged commit e402b94 into 3.2 May 22, 2018
@manuasir manuasir deleted the 3.2-dev-refactor branch May 22, 2018 18:01
@manuasir manuasir modified the milestones: v3.3.0, v3.2.3 May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant