Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/crud role mapping #1169

Merged
merged 20 commits into from
Nov 11, 2021
Merged

Feat/crud role mapping #1169

merged 20 commits into from
Nov 11, 2021

Conversation

eze9252
Copy link
Contributor

@eze9252 eze9252 commented Nov 3, 2021 •
edited
Loading

Hi team,
This PR added new CRUD of Roles Mapping on the security section.
Closes #1153

List Role Mapping:

Captura de pantalla de 2021-11-03 18-41-04

Create Role Mapping:
Captura de pantalla de 2021-11-03 18-54-02

See and update Role Mapping:
Captura de pantalla de 2021-11-03 18-41-14

Delete Role Mapping:
Captura de pantalla de 2021-11-03 18-54-11

@eze9252 eze9252 self-assigned this Nov 3, 2021
@eze9252 eze9252 linked an issue Nov 3, 2021 that may be closed by this pull request
CRUD operations for Role mapping #1153
Closed
4 tasks
gabiwassan
gabiwassan suggested changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some simple comments, and please check to apply prettier for the style code.

SplunkAppForWazuh/appserver/static/js/directives/wz-table/wz-table.html Outdated
class='fa fa-fw fa-check'></i> Confirm</md-button>
</div>
</div>
<td ng-if="isLookingGroup() " ng-click="$event.stopPropagation()"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this method isLookingGroup() is for Agents Groups

SplunkAppForWazuh/appserver/static/js/directives/wz-table/wz-table.html Outdated
Comment on lines 379 to 380
<span class="font-size-12 wz-padding-left-8">{{item.name}} will be removed from
this group</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is referred to groups not to Role Mapping 🤓

AlexRuiz7 and others added 9 commits November 5, 2021 15:47
@AlexRuiz7 @eze9252
Apply formatter
17c90f2
@AlexRuiz7 @eze9252
Checkpoint
168a256
@AlexRuiz7 @eze9252
Fix import problems on the new Users controller
354a112
@AlexRuiz7 @eze9252
Implement services to get Splunk users and current user logged in.
4eec00a 
- Implements a new backend controller that provides endpoints to retrieve the user logged in the app as well as a list with every users registered
in the Splunk's instance.
- Implements a new frontend service (class) whom methods consume the new endpoints.
@AlexRuiz7 @eze9252
Set log level back to 'info'
9de61fe
@AlexRuiz7 @eze9252
Improve exception handling
1996104
@AlexRuiz7 @eze9252
Update get_agents_status.py
b59f920
@eze9252
fix some errors and add splunk users
af445b7
@eze9252
fix username field
e617336
@Desvelao
Copy link
Member

Desvelao commented Nov 8, 2021

review:

Testing:

  • Table
    • List role mapping ✅
      suggestion: use Roles instead of roles for the column. Is there some limitation to do this?
      suggestion: use the role name instead of its ID in the role mapping table
      suggestion: the last column should be named Actions. See another security tabs.
      image
    • Manage columns visibility ✅
    • action:edit (open the editing view) ✅
    • action:delete ❌
      • Cancel ✅
      • Confirm ❌
        issue: The role mapping rule is deleted but there is an error when trying to list again and update the table
  • Add new role mapping
    question: Should we add the rule JSON editor?
    • Role multi-select ✅
    • User multi-select ✅
    • action:save ❌
      issue: If I try to edit the role mapping an error is thrown and the save button keeps processing indefinitely:
      image
      Request:
<SPLUNK_HOST>:<SPLUNK_PORT><SPLUNK_BASE>/api/request

image

Response:

{"error": "'error'"}

@eze9252 eze9252 merged commit df35633 into feature/1148-RBAC-management-section-security-states Nov 11, 2021
@AlexRuiz7 AlexRuiz7 deleted the feat/crud-role-mapping branch November 22, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabiwassan gabiwassan gabiwassan requested changes

Assignees

@eze9252 eze9252

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRUD operations for Role mapping
4 participants
@eze9252 @Desvelao @gabiwassan @AlexRuiz7