Skip to content

Conversation

@felipegonzalezmv
Copy link
Contributor

Description

Remove the "Top 5 agents" visualization from IT Hygiene > Identity > Groups view and update the field label from "Group name" to "Groups" for better consistency and clarity.

Issues Resolved

Evidence

image

Test

  1. Navigate to IT Hygiene > Identity > Groups
  2. Verify that the "Top 5 agents" visualization is no longer displayed
  3. Confirm that the field label shows "Groups" instead of "Group name"
  4. Ensure the remaining visualizations (Top 5 groups and Unique groups metric) are still functioning correctly

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

- Remove Top 5 agents visualization from IT Hygiene > Identity > Groups
- Change 'Top 5 groups' label to 'Groups' for better clarity

Fixes #7791
- Update fieldCustomLabel from 'Group name' to 'Groups' to match the title
- Completes the label standardization requested in issue #7791
- Change label from 'Groups' to 'Top 5 groups' for improved clarity in the overview users groups tab.
- This update aligns with the ongoing label standardization efforts.
@felipegonzalezmv felipegonzalezmv linked an issue Oct 1, 2025 that may be closed by this pull request
2 tasks
CHANGELOG.md Outdated

- Updated OS logos [#7712](https://github.com/wazuh/wazuh-dashboard-plugins/pull/7712)
- Changed "Services" tab label to "Listeners" in IT Hygiene > Networks [#7742](https://github.com/wazuh/wazuh-dashboard-plugins/pull/7742)
- Removed "Top 5 agents" visualization and changed "Top 5 groups" label to "Groups" in IT Hygiene > Identity > Groups [#7792](https://github.com/wazuh/wazuh-dashboard-plugins/pull/7792)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't been removed from previous versions. Instead please add this pull request to the section creation entry:
https://github.com/wazuh/wazuh-dashboard-plugins/blob/4.14.0/CHANGELOG.md?plain=1#L10

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in this commit 259cb84

@yenienserrano yenienserrano changed the title Change/7791 remove top 5 agents visualization from it hygiene identity groups Remove top 5 agents visualization from it hygiene identity groups Oct 1, 2025
yenienserrano
yenienserrano previously approved these changes Oct 1, 2025
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

…etric

- Replace manual getVisStateUniqueGroupsMetric implementation with existing getVisStateMetricUniqueCountByField utility
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 78.72% ( 185 / 235 )
Branches 62.72% ( 69 / 110 )
Functions 61.7% ( 29 / 47 )
Lines 78.72% ( 185 / 235 )

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Wazuh Core plugin code coverage (Jest) test % values
Statements 48.3% ( 443 / 917 )
Branches 43.9% ( 173 / 394 )
Functions 44.81% ( 147 / 328 )
Lines 48.45% ( 440 / 908 )

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Main plugin code coverage (Jest) test % values
Statements 18.09% ( 5679 / 31377 )
Branches 12.56% ( 2511 / 19989 )
Functions 18.96% ( 1459 / 7695 )
Lines 18.29% ( 5524 / 30196 )

Copy link
Member

@gonzaarancibia gonzaarancibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM

Image

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Image

@asteriscos asteriscos merged commit 01cccfb into 4.14.0 Oct 2, 2025
5 checks passed
@asteriscos asteriscos deleted the change/7791-remove-top-5-agents-visualization-from-it-hygiene-identity-groups branch October 2, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Top 5 agents visualization from It Hygiene > Identity > Groups

4 participants