Skip to content

Changes on It hygiene > Services #7790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2025
Merged

Changes on It hygiene > Services #7790

merged 4 commits into from
Oct 2, 2025
+11 −19

Conversation

@yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Oct 1, 2025 •
edited
Loading

Description

Removed process.user.name and process.executable columns from the IT Hygiene > Services data grid

Replaced the "Top 5 process user names" visualization with a Unique count of the service.name field

Issues Resolved

Evidence

image

Test

  1. Navigate to IT Hygiene > Services
  2. The data grid should not have the fields: process.user.name and process.executable
  3. Should have both visualizations: Top 5 services and Unique services.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Oct 1, 2025
@yenienserrano yenienserrano linked an issue Oct 1, 2025 that may be closed by this pull request
Remove process.user.name and process.executable columns from IT Hygiene > Services #7789
Closed
2 tasks
@yenienserrano yenienserrano marked this pull request as ready for review October 1, 2025 13:05
@felipegonzalezmv felipegonzalezmv self-requested a review October 1, 2025 13:31
@felipegonzalezmv
Copy link
Contributor

Test 🟢

image

felipegonzalezmv
felipegonzalezmv previously approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@felipegonzalezmv felipegonzalezmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢
LGTM! 🟢

gonzaarancibia
gonzaarancibia previously approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@gonzaarancibia gonzaarancibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM
🟢 CR

Image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Wazuh Core plugin code coverage (Jest) test % values
Statements 48.3% ( 443 / 917 )
Branches 43.9% ( 173 / 394 )
Functions 44.81% ( 147 / 328 )
Lines 48.45% ( 440 / 908 )

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 78.72% ( 185 / 235 )
Branches 62.72% ( 69 / 110 )
Functions 61.7% ( 29 / 47 )
Lines 78.72% ( 185 / 235 )

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Main plugin code coverage (Jest) test % values
Statements 18.09% ( 5679 / 31379 )
Branches 12.56% ( 2511 / 19989 )
Functions 18.95% ( 1459 / 7696 )
Lines 18.29% ( 5524 / 30198 )

gonzaarancibia
gonzaarancibia approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@gonzaarancibia gonzaarancibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM

Image Image

asteriscos
asteriscos approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Image

@asteriscos asteriscos merged commit e7acc0f into 4.14.0 Oct 2, 2025
5 checks passed
@asteriscos asteriscos deleted the change/7789-remove-processusername-and-processexecutable-columns-from-it-hygiene-services branch October 2, 2025 08:44
@asteriscos asteriscos mentioned this pull request Oct 10, 2025
Closed
3 tasks
@guidomodarelli guidomodarelli mentioned this pull request Oct 20, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asteriscos asteriscos asteriscos approved these changes

@felipegonzalezmv felipegonzalezmv felipegonzalezmv approved these changes

@gonzaarancibia gonzaarancibia gonzaarancibia approved these changes

Assignees

@yenienserrano yenienserrano

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove process.user.name and process.executable columns from IT Hygiene > Services

4 participants

@yenienserrano @felipegonzalezmv @asteriscos @gonzaarancibia