Skip to content

Commit

Permalink
Minor bug fix. Wasn't properly indicating "good" failure of CABiCGStab
Browse files Browse the repository at this point in the history
back to the MG solver when we want to do additional smooths.  I noticed
this when a case I was running was doing additional bottom smooths in
the BiCG case but was not in the CABiCG case.  Curiously, in that case,
both the CiCG and the CABiCG MG solves converged in the same number of
iterations. The additional smooths done when the BiCG didn't solve the
bottom problem to the requested precision, didn't do much of anything,
except waste time.
  • Loading branch information
lijewski committed Aug 30, 2013
1 parent 611715b commit 6baa30a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Src/LinearSolvers/C_CellMG/CGSolver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ CGSolver::solve_cabicgstab (MultiFab& sol,
}
}

if ( niters == maxiter && !BiCGStabFailed && !BiCGStabConverged)
if ( niters >= maxiter && !BiCGStabFailed && !BiCGStabConverged)
{
if ( L2_norm_of_resid > L2_norm_of_rt )
{
Expand Down

0 comments on commit 6baa30a

Please sign in to comment.