Wire Up Endpoints #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meierj-wayscript
force-pushed
the
gen-194-create-python-wayscriptcontext-v0
branch
from
c3a3595 to
6a73bfc
Compare
Also remove api version, as it's not currently used anywhere. I'm guessing we'll eventually need to add it back.
jeffbuswell
reviewed
Jul 28, 2021
jeffbuswell
reviewed
Jul 28, 2021
jeffbuswell
reviewed
Jul 28, 2021
jeffbuswell
approved these changes
Jul 28, 2021
Contributor
jeffbuswell
left a comment
jeffbuswell
left a comment
There was a problem hiding this comment.
Looks awesome overall! Just a couple minor nits - feel free to address in this PR or a subsequent one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Checklist
Related issues