Skip to content

Conversation

@hrgreene
Copy link
Contributor

@hrgreene hrgreene commented Nov 16, 2022

Change description

New SDK function, allows process running on wayscript to create or update a secret

from wayscript import secret_manager

secret_manager.set_secret("key", "value")

Checklist

  • Application changes have been tested and automated tests have been added, if applicable
  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Related issues

Fixes #1909

@linear
Copy link

linear bot commented Nov 16, 2022

GEN-1909 Endpoint for updating secrets

Add this to both python and node SDK

Copy link

@samkam samkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@aroxby-wayscript aroxby-wayscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! A little cleanup suggested.

Copy link

@aroxby-wayscript aroxby-wayscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hrgreene hrgreene merged commit 3394488 into master Nov 29, 2022
@hrgreene hrgreene deleted the GEN-1909-update-secret-via-sdk branch November 29, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants