Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix promotion don't delete files issues #67

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Fix promotion don't delete files issues #67

merged 2 commits into from
Jun 1, 2023

Conversation

Oded-B
Copy link
Collaborator

@Oded-B Oded-B commented Jun 1, 2023 •
edited
Loading

Description

Apparently... the way we sync directories(set the target dir git tree object SHA) doesn't delete files!!!! GH just "merges" the old and new tree objects.
So for now, I'll just go over all the files and explicitly add delete tree entries :(

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@Oded-B Oded-B marked this pull request as ready for review June 1, 2023 12:46
@Oded-B Oded-B merged commit f64100c into main Jun 1, 2023
@Oded-B Oded-B mentioned this pull request Jun 2, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Oded-B