Fix release publishing workflows (#72)

* Fix release publishing workflows

Make GH actions work for release publishing

* Add cleanup just in case

* Fix clean for windows

* Build PR images only after approval

.github/workflows/build-binaries.yaml

@@ -26,3 +26,6 @@ jobs:
 
       - name: List files
         run: file output/*
+
+      - name: Cleanup
+        run: rm output/*

.github/workflows/build-images.yaml

@@ -1,13 +1,17 @@
 name: Build Docker images
 
-on: [pull_request]
+on:
+  pull_request_review:
+    types: [submitted]
 
 env:
   REGISTRY: ghcr.io
   IMAGE_NAME: ${{ github.repository }}
 
 jobs:
   build-and-push-image:
+    # Build image only if PR is approved to avoid having too many random images
+    if: github.event.review.state == 'approved'
     runs-on: ubuntu-latest
     permissions:
       contents: read

.github/workflows/publish-release-binaries.yaml

@@ -40,3 +40,6 @@ jobs:
         with:
           files: "output/*"
           repo-token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Cleanup
+        run: rm output/*

Makefile

@@ -46,23 +46,19 @@ test: $(VENDOR_DIR)
 .PHONY: build-ubuntu-latest
 build-ubuntu-latest: $(VENDOR_DIR) $(OUTPUT_DIR)
 	CGO_ENABLED=1 go build -a -ldflags '-extldflags "-static"' -o output/minigun .
-	tar czf output/minigun-linux-amd64.tar.gz output/minigun
-	rm -f output/minigun
+	cd output && file minigun && tar czf minigun-linux-amd64.tar.gz minigun && rm -f minigun
 	GOARCH=arm64 CGO_ENABLED=0 go build -a -ldflags '-extldflags "-static"' -o output/minigun .
-	tar czf output/minigun-linux-arm64.tar.gz output/minigun
-	rm -f output/minigun
+	cd output && file minigun && tar czf minigun-linux-arm64.tar.gz minigun && rm -f minigun
 
 .PHONY: build-macos-latest
 build-macos-latest: $(VENDOR_DIR) $(OUTPUT_DIR)
 	CGO_ENABLED=1 go build -a -ldflags '-extldflags "-static"' -o output/minigun .
-	tar czf output/minigun-darwin-amd64.tar.gz output/minigun
+	cd output && file minigun && tar czf minigun-darwin-amd64.tar.gz minigun && rm -f minigun
 	rm -f output/minigun
 	GOARCH=arm64 CGO_ENABLED=0 go build -a -ldflags '-extldflags "-static"' -o output/minigun .
-	tar czf output/minigun-darwin-arm64.tar.gz output/minigun
-	rm -f output/minigun
+	cd output && file minigun && tar czf minigun-darwin-arm64.tar.gz minigun && rm -f minigun
 
 .PHONY: build-windows-latest
 build-windows-latest: $(VENDOR_DIR) $(OUTPUT_DIR)
 	CGO_ENABLED=1 go build -a -ldflags '-extldflags "-static"' -o output/minigun.exe .
-	tar czf output/minigun-win64.tar.gz output/minigun.exe
-	rm -f output/minigun.exe
+	cd output && tar czf minigun-win64.tar.gz minigun.exe && rm -f minigun.exe