Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Renovate #15

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Add Renovate #15

merged 5 commits into from
Oct 17, 2022

Conversation

pdelre
Copy link
Contributor

@pdelre pdelre commented Oct 14, 2022

Description

This ports the Dependabot configuration to Renovate. In particular, it only sets Renovate to update github-actions. A preview of expected PRs is below and in https://github.com/pdelre/kdave/pull/1

image

Resolves #13
Closes #11

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)
    • Project Maintenance Improvement

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@draco2003
Copy link
Contributor

Definitely resolves the Dependabot -> Renovate switch of existing functionality, but doesn't actually track/help manage the dependencies of the software itself.

Happy to have that be part of this PR, or we should create a new issue to make sure we add that functionality as a fast follow.

@draco2003
Copy link
Contributor

Ditto with adding renovate config linting workflow so that we don't have a broken config, or break it in the future:
Example: https://github.com/wayfair-incubator/forker/blob/main/.github/workflows/build.yml#L21

@lelia lelia requested review from a team and removed request for a team October 14, 2022 15:58
@pdelre
Copy link
Contributor Author

pdelre commented Oct 14, 2022

Definitely resolves the Dependabot -> Renovate switch of existing functionality, but doesn't actually track/help manage the dependencies of the software itself.

I've reached out to the maintainers which are currently on holiday.

Ditto with adding renovate config linting workflow

Added. Thanks for the catch.

@amelbakry amelbakry merged commit 08ab922 into wayfair-incubator:main Oct 17, 2022
@pdelre pdelre deleted the add-renovate branch October 17, 2022 12:40
@pdelre pdelre mentioned this pull request Oct 28, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧹 Add Renovate
3 participants