refactor: hide egl code behind feature in libwayshot#320
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 17.63% 17.66% +0.02%
==========================================
Files 19 20 +1
Lines 2988 2983 -5
==========================================
Hits 527 527
+ Misses 2461 2456 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hmm, probably we don't even need it as default feature in cli... |
|
oh.. sorry, this is just a draft. I should not approve it now |
|
Yeah, my bad. I've opened it yesterday, but now I thought that maybe we don't need that feature on by default in cli, since we don't use egl on it to capture screenshot anyway |
|
@Decodetalkers |
This PR hides
egl-related code inlibwayshotbehind feature (enabled by default).This may seem useless at the moment, but this is part of further refactoring before implementing optional
vulkansupport. I've been testing and using it in my fork for ~2 weeks and things are looking good.Breaking changes
While this is not breaking for most users,
default-features = falseusers will loseeglsupport. Migration step is to add feature, e.g.libwayshot = { version = "...", default-features = false, features = ["png", "egl"] }.