Node api finality by esuwu · Pull Request #1897 · wavesplatform/gowaves

esuwu · 2025-11-11T09:24:29Z

No description provided.

alexeykiselev · 2025-11-28T07:31:06Z

pkg/wallet/stub.go

-func (s Stub) SignTransactionWith(pk crypto.PublicKey, tx proto.Transaction) error {
-	panic("Stub.SignTransactionWith: Unsupported operation")
+func (s Stub) SignTransactionWith(_ crypto.PublicKey, _ proto.Transaction) error {
+	panic("Stub.SignTransactionWith: Unsopported operation")


Does the word “unsOpported” exist?

alexeykiselev · 2025-11-28T07:36:36Z

pkg/wallet/embedded_wallet.go

+	return crypto.PublicKey{}, ErrPublicKeyNotFound
+}
+
+func (a *EmbeddedWalletImpl) BlsPairByWavesPK(publicKey crypto.PublicKey) (bls.SecretKey, bls.PublicKey, error) {


"Bls" should be "BLS".

alexeykiselev · 2025-11-28T07:41:06Z

pkg/state/commitments.go

+
+// FindEndorserPKsByIndexes returns BLS endorser public keys using
+// commitment indexes stored in FinalizationVoting.EndorserIndexes.
+func (c *commitments) FindEndorserPKsByIndexes(


Why "PKs" and "indexes", not "PK" and "index", the function returns only one public key and accepts only one index.

alexeykiselev · 2025-11-28T07:55:02Z

pkg/state/finalization.go

+	"github.com/wavesplatform/gowaves/pkg/proto"
+)
+
+const finalizationKey = "finalization"


All keys have to be introduced in

gowaves/pkg/state/keys.go

Line 139 in 8b0ac77

commitmentKeyPrefix

alexeykiselev · 2025-11-28T07:56:05Z

pkg/state/finalization.go

+var ErrNoFinalizationHistory = errors.New("no finalization in history")
+
+type finalizationItem struct {
+	Block                proto.BlockHeader `cbor:"0,keyasint,omitempty"`


No need to store block header second time here, can be retrieved by height or blockID.

alexeykiselev · 2025-11-28T08:05:14Z

pkg/state/finalization.go

+func (fr *finalizationRecord) unmarshalBinary(data []byte) error { return cbor.Unmarshal(data, fr) }
+
+type finalizations struct {
+	hs *historyStorage


As we discussed the finalization storage should not be a history storage. In case of using history the rollback will happen automatically, but the idea of finalization records that they are irreversible.

The finalization now contains only one item, I kept the history storage. Moved it to the other PR

alexeykiselev · 2025-11-28T08:07:52Z

pkg/state/appender.go

+		return false, fmt.Errorf("failed to build endorsement message: %w", err)
+	}
+
+	// 2. Восстанавливаем endorser PK по индексам


Oh no! Please use English only.

alexeykiselev · 2025-11-28T08:10:30Z

pkg/state/appender.go

 	return nil
 }

+func (a *txAppender) isLastBlockFinalized(


Strange naming, is it better to name the function "updateFinalization" or "calculateFinalization"?

alexeykiselev · 2025-11-28T08:11:14Z

pkg/state/appender.go

+	if err != nil {
+		return false, err
+	}
+	msg, err := proto.EndorsementMessage(


Why construct an endorsement message here?

Ah, I see, it's for block header validation. I'd rather move this function to proto package, somewhere near block declaration or even made it a part of Block type.

Which file are you suggesting to move it to?

Because this function EndorsementMessage is already in proto

alexeykiselev · 2025-11-28T08:17:12Z

pkg/api/routes.go

Corresponding `pkg/client' parts have to be implemented.

esuwu · 2025-12-03T09:44:11Z

Moved storage to add-network-messages

pkg/api/app.go

nickeskov · 2025-12-15T00:44:44Z

pkg/api/node_api.go

+	activationHeight, err := a.state.ActivationHeight(int16(settings.DeterministicFinality))
+	if err != nil {
+		return fmt.Errorf("failed to get DeterministicFinality activation height: %w", err)
+	}


What if activation height is unknown at the moment? I think the endpoint returns 500 error in such case.

Any changes?

Should be handled properly.

pkg/api/node_api.go

nickeskov · 2025-12-15T01:20:18Z

pkg/api/node_api.go

+type GeneratorInfo struct {
+	Address       string `json:"address"`
+	Balance       uint64 `json:"balance"`
+	TransactionID string `json:"transactionID"`
+}


This struct must be package private.

It's now used in 2 different packages

Yes, but it's an implementation details of our API. It should not be exported to the client packages.

pkg/client/generators.go

pkg/node/blocks_applier/node_mocks.go

pkg/wallet/stub.go

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

nickeskov

Please, check comments for pkg/api/node_api.go.

nickeskov · 2026-02-03T02:07:30Z

pkg/api/node_api.go

+	activationHeight, err := a.state.ActivationHeight(int16(settings.DeterministicFinality))
+	if err != nil {
+		return fmt.Errorf("failed to get DeterministicFinality activation height: %w", err)
+	}


Should be handled properly.

nickeskov · 2026-02-03T02:08:08Z

pkg/api/node_api.go

+	periodStart, err := state.CurrentGenerationPeriodStart(activationHeight, height,
+		a.app.settings.GenerationPeriod)


Should be handled properly.

* Added bls signature methods * Added comments * Enforced no duplicates in signatures and public keys * Fixed linter issues * Added pop method * Added public key validation * Added block finality schemas * Added protobuf schemas * Updated protobuf generated files * Gosec option to exclued generated files added to security workflow. * Set protobuf-schemas submodule to track the branch. Submodule updated to the latest commit. * Generated protobuf code updated to the latest schema. * WIP: Basic structure of CommitToGeneration transaction implemented. * BLS package refactoring. Package renamed from blssig to bls. Crypto primitives SecretKey, PublicKey and Signature were added. Public functions Sing and Verify reimplemented to use new primitives. Function to create aggregated signature from multiple Waves secrets keys was removed because it was useful only in tests. PoP functions moved to separate file. * Added test on keys, signature and messages collected from Scala. * Added tests on PoP functions. Fixed review issues. * Fixed linter issues. * Protobuf schemas updated and code regenerated. * Tidy go modules. * Some transactions fields renamed according to Protobuf schema. BLS package used to validate PoP during transaction validation. * Protobuf conversion for CommitToGeneration transaction implemented. Test on Protobuf round-trip added. * Introduced constants for Protobuf versions of transactions Reduced cognitive complexity of the new test. * Added test on validation of CommitToGeneration transaction. Added test on JSON serialization of new transaction. WIP: added skipped test on Scala compatibility of JSON serialization. * WIP: Started implementation of commitment transaction conversion into Ride object. Refactored Encode2CBigInt function. * Returned usage of a constant. * Finished endorsement pool * Added endorsement handling to ng * Finalized when key block arrives * Fixed linter issues * WIP: Generation Period length added to functionality settings. BLS keys added to test global variables. Minimal fee amount added for CommitToGeneration transaction. Constants introduced for other fees. Function to calculate next generation period start implemented and tested. Basic checks of CommitToGeneration transaction against state implemented and tested. * WIP: Commitments storage added to state. Basic functions implemented. Commitments serialization implemented and tested. Checks of CommitToGeneration transaction against storage of commitments added to transaction checker. Tests on new checks implemented. New setting MaxGenerators added to networks configurations. StageNet settings updated. * Modernize issues fixed. * Fixed pr issues * Changed the way of calculation of generation period start. Tests updated and added. * Returned a pointer * Change CommitToGeneration transaction number to 19. * TransactionType stringer fixed. Test on JSON serialization fixed. * Review issues fixed. Unused fields and arguments removed. Data emptiness by length check added. Error messages improved and tests updated. Compile time interface check added. * Fixed for tests * Added dummy implementation of some methods * WIP: Transaction differ for CommitToGeneration transaction implementation started. New snapshot type GenerationCommitmentSnapshot added. Snapshot hashing for new snapshot type implemented. * Added endorse block to actions * Fixed the activation check * Functions newestExists and newestSize added to commitments storage. Test on CommitToGeneration transaction performer added. * WIP: CBOR balances serialization implemented. * Balances calculation fixed. Linter issues fixed. * Added conversion of LeaseIn and LeaseOut to int64 with overflow. Warning on such conversions added. * Added conflict endorsements, fixed endorser commitment records, sorted endorsers records, added actions messages * Added an endorsement message test * Fixed 'more or less' in voting finalization * Benchmark on wavesBalanceRecord serialization/deserialization added. * Deprecated functions replaced. * Updated go-safecast package to v2. * Fixed errors check in commitments storage. * Fixed PR issues * Fixed linter issues * Replaced array to heap * Updated microblock * Updateed protobuf schemas * Regenerated proto structures * Added a test * Fixed empty endorsers when finalizing for microblock * Updated bls signature type in finalization and endorsements * Updated protobuf schemas * regenerated proto structures * Fixed serializing * Added a feature check before adding fin to microblock * Reset Deposits upon generation period end. (#1882) * WIP: Reset Deposits upon generation period end. Functions to calculate generation periods start and end added and modified according to Scala implementation. Tests updated and added. Function to detect generation period end added. Function to reset deposits added. * WIP: Integration test on CommitToGenerationTransaction and deposits resets added. Interagation tests NodeUniversalClient improved. New BlockchainOptions added. BLS keys generation and storing added to itests AccountInfo. BLS Sigrnature JSON deserialization fixed. CommitToGenerationTransaction type added to GuessTransactionType function. MaxGenerators field of FunctionalitySettings renamed to MaxEndorsements. Support for new transaction added to txAppender. Deposit application added to snapshot application of CommitToGeneration transaction. Check on commitments limit for generation period removed. Compliment test removed. Linter fixes. * Excessive logging removed. * Test on deposit rollback added. Test made independent of starting height. * Review issues fixed. Few TODOs resolved. Size functions of commitments storage removed. Safe addition of deposit added. Generation period end function used in state to check if generation period is over. * Key generation options added for BLS secret key generation. (#1910) Options to set custom salt or random salt added. Option to set key info added. Tests on key generation added. * Check on repeated usage of endorser public key from another waves account added. Duplicated code extracted in a function. Test added. * Fixed a mistake * Added a check whether the endorsement pool is empy * Update legacy state hash (#1901) * WIP: Reset Deposits upon generation period end. Functions to calculate generation periods start and end added and modified according to Scala implementation. Tests updated and added. Function to detect generation period end added. Function to reset deposits added. * WIP: Integration test on CommitToGenerationTransaction and deposits resets added. Interagation tests NodeUniversalClient improved. New BlockchainOptions added. BLS keys generation and storing added to itests AccountInfo. BLS Sigrnature JSON deserialization fixed. CommitToGenerationTransaction type added to GuessTransactionType function. MaxGenerators field of FunctionalitySettings renamed to MaxEndorsements. Support for new transaction added to txAppender. Deposit application added to snapshot application of CommitToGeneration transaction. Check on commitments limit for generation period removed. Compliment test removed. Linter fixes. * Excessive logging removed. * Test on deposit rollback added. Test made independent of starting height. * WIP: Legacy state hash structures moved to separate file. Refactoring of structures in progress. * StateHash structure renamed to StateHashV1. Second version of StateHash with additional field implemented as StateHashV2. Tests on state hash moved to separate file. Total hash generation reimplemented with WriteTo function. Binary serialization of StateHashV1 reimplemented with ReadFrom and WriteTo functions. Wrapper SizedBlockID added to support serialization/deserialization of BlockID prepended with length. * StateHashDebug interface added. Both implementations updated accordingly. Debug API and statehash utility updated to produce and use new interface. BaseTarget reporting added to StateHashDebugV2. * Required getters added to StateHash interface and implementations. HTTP client debug updated to use proto.StateHash interface. Itest HTTP client updated. Utility statecmp updated and refactored a bit. * StateHash version selection upon finality activation implemented. WIP: Broken test added. * Legacy state hash Scala compatibility test implemented. * Linter issue fixed. * Test fixed. * Review issues fixed. UnmarshalBinary added to StateHash interface. Constructors to create appropriate state hashes added. Test added. Save of state hash fixed. * Removed finalization on key block * Fixed test * Added finalization storage * Fixed a panic * Removed extra fields go mod * Added punishment for conflict endorsements * Pulled latest changes from protobuf-schemas * Fixed a merging error * Regenerated proto files * Updated protobuf gen files version * Added extra lines at the end of files * Added one more line at the end of file * Fixed timing of removing bad generator * Added finalization debug logs * Removed a line * Added block endorsement from miner when received key block * Changed block to parent block to endorse * Moved sending endorsement from mining key block to receiving key block * Added cleaning endorsement pool upon receiving key block * Fixed a mistake with building message for signature * Fixed a mistake with comparing endorsement messages * Fixed FinalizedBlockHeight field * Added a check whether addresses are in the commitment records before endorsing * Added more meaningful errors * Added the number of args of fsm event validation * Added a comma * Added a check on max_endorsements * Removed useless code * Fixed logging of new finalization voting * Fixed logging of new finalization voting * Fixed retrieving finalized blockIDs * Fixed a log * Fixed underflow bug with calculating finalized height * Fixed a formatting issue * Added logs when key not found in commitment records * Added endorsementIDs cache * Added logs with endorsers * Fixed finalized height calculation * Fixed linter issues * Added a test for commitments * Fixed the block signature bug where finalization was added after block was signed * Added block generator balance to the total endorsers balance * Added a clearer log message to get block action * Added saving of block generator to endorsement pool * Added block generator to endorsement pool upon receiving new block * Fixed a bug with microblock protobuf not having finalization voting * Added finalization voting for microblock in other places * Added more meaningful logs and errors * Microblock finalization is nil if block finalization is nil * Added more logs * removed useless calculation * removed merging lines * Added more logs * Added missing finalization voting in missing conversion * Removed fixed size from finalizatiom history record * Removed fixed size from finalizatiom history record * Added more logs * Fixed finalization signature check over grandparent's block * Fixed a linter error * Checking generating balance on previous height instead of latest * Checking generating balance on previous height instead of latest * Stored the correct endorsed block height instead of the current one when finalized * Split big function into 2 * Committed generators balances legacy state hash (#1978) * Add legacy state hash methods for 'commitments'. * Refactoring of 'NewLegacyStateHash' constructor. * Add committed generators balances hash calculation. * Add new field to statehash calculation, tests updated. * Outdated comments updated. Uninformative comments removed. --------- Co-authored-by: Alexey Kiselev <alexey.kiselev@gmail.com> * Wrapped an error * Added limit to auto rollback according to the finality spec * Added limit to auto rollback according to the finality spec * Node api finality (#1897) * Drafted endpoints for API * Updated protobuf structures * Added finalization storage * Fixed errors * Fixed old code * SignCommitGeneration draft * Finished signCommitToGeneration * Added finalization validation * Added a finalization processor for tx appender * Merged again * Added clients methods * Added http client itests * Fixed an error * Updated protobuf version * Implemented nickeskov's suggestions * Implemented some AI suggestions * Made the tx signing handle all tx types * Fixed an fmt error * Added a test for transactionSign * Fixed linter erors * Added a specific error * Added logs * Fixed a linter error * Changed commitment transaction fee * Allowed for custom transaction fee in commitment tx sign api * Fix modernize. * Changed fmt to errors wrap --------- Co-authored-by: Nikolay Eskov <mr.eskov1@yandex.ru> * Linter issues fixed. * Auto rollback finalization 2 (#2005) * Added a soft rollback * Added commit after saving finalization after rollback * Added a check whether finalization block exists * Changed newest block id by height * Set currentBlockID when finalization is set * Fixed PR issues * Fixed a typo * Modernize issue fixed. --------- Co-authored-by: esuwu <sanya554455@gmail.com> --------- Co-authored-by: Alexey Kiselev <alexey.kiselev@gmail.com> Co-authored-by: Nikolay Eskov <mr.eskov1@yandex.ru>

esuwu added 6 commits November 11, 2025 10:23

Drafted endpoints for API

d5bcb7d

Updated protobuf structures

4be1b1e

Merge branch 'add-network-messages' into node-api-finality

52af168

Added finalization storage

d033dc9

Fixed errors

402ef6f

Fixed old code

1caf2a1

esuwu requested a review from alexeykiselev November 24, 2025 09:13

esuwu added 5 commits November 24, 2025 11:27

SignCommitGeneration draft

82a7a2e

Merged from finality network messages

aac66f8

Finished signCommitToGeneration

350e93d

Merged from add network messages

9b96f0f

Added validation of finalization

20bf1d8

alexeykiselev requested changes Nov 28, 2025

View reviewed changes

esuwu added 3 commits December 3, 2025 09:50

Added finalization validation

282bf9f

Added a finalization processor for tx appender

cd82ba3

Merged from add-network-messages

51f714d

esuwu added 5 commits December 5, 2025 14:24

Merged from add-network-messages

44ad778

Merged again

40c3d02

Added clients methods

5dce8da

Added http client itests

b77abc1

Fixed an error

6e83e89

nickeskov requested review from Copilot and nickeskov December 15, 2025 00:56

Copilot started reviewing on behalf of nickeskov December 15, 2025 00:57 View session

nickeskov reviewed Dec 15, 2025

View reviewed changes

Copilot AI reviewed Dec 15, 2025

View reviewed changes

esuwu added 2 commits December 17, 2025 14:28

Updated protobuf version

2bfd983

Merge branch 'add-network-messages' into node-api-finality

d17d321

nickeskov requested a review from Copilot December 17, 2025 22:59

esuwu and others added 24 commits January 23, 2026 13:51

Fixed linter erors

bfb4ac9

Merge branch 'add-network-messages' into node-api-finality

f815e96

Added a specific error

c7f964d

Merge branch 'add-network-messages' into node-api-finality

67f82e3

Merge branch 'add-network-messages' into node-api-finality

0057141

Merge branch 'add-network-messages' into node-api-finality

0f7a7b1

Merge branch 'add-network-messages' into node-api-finality

e057365

Merge branch 'add-network-messages' into node-api-finality

34bdf95

Merge branch 'add-network-messages' into node-api-finality

426e67a

Merge branch 'add-network-messages' into node-api-finality

3134453

Merge branch 'add-network-messages' into node-api-finality

37b3522

Merge branch 'add-network-messages' into node-api-finality

bb0c09e

merged from add-network-messages

57ad53a

Merge branch 'add-network-messages' into node-api-finality

d513e1a

Merge branch 'add-network-messages' into node-api-finality

743846e

Merge branch 'add-network-messages' into node-api-finality

8c4cb9b

Added logs

022ac5f

merged from add-network-messages

160416f

Fixed a linter error

7b1e186

Merge branch 'add-network-messages' into node-api-finality

46cabb3

Changed commitment transaction fee

a2ac998

Merge branch 'add-network-messages' into node-api-finality

ac0eab9

Allowed for custom transaction fee in commitment tx sign api

32413f5

Fix modernize.

bff2a60

nickeskov reviewed Feb 3, 2026

View reviewed changes

esuwu added 2 commits February 3, 2026 16:26

Merge branch 'add-network-messages' into node-api-finality

e227184

Changed fmt to errors wrap

c623adc

esuwu merged commit 0969bcb into add-network-messages Feb 3, 2026
9 checks passed

esuwu deleted the node-api-finality branch February 3, 2026 15:58

		periodStart, err := state.CurrentGenerationPeriodStart(activationHeight, height,
		a.app.settings.GenerationPeriod)

Conversation

esuwu commented Nov 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

esuwu commented Dec 3, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

nickeskov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees