Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused direct and proxy connection handlers #123

Merged
merged 1 commit into from
Dec 1, 2022
Merged

remove unused direct and proxy connection handlers #123

merged 1 commit into from
Dec 1, 2022

Conversation

LukeWinikates
Copy link
Contributor

These two files look to be unused, so it seems helpful to remove them.

@LukeWinikates
Copy link
Contributor Author

@keep94 this is a small change extracted from #120 🙇‍♂️

keep94
keep94 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@keep94 keep94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch finding this dead code. LGTM.

@keep94 keep94 merged commit 46a5ee8 into wavefrontHQ:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keep94 keep94 keep94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukeWinikates @keep94