Added support for repomd_gpg_url config parmeter #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersions >= 1.21.10-2)
|
You need to provide tests for the new feature that demonstrates it is functioning. Until this this is blocked on no tests. |
waveclaw
added
bug
enhancement
NO TESTS
waveclaw
approved these changes
Nov 27, 2018
waveclaw
added a commit
that referenced
this pull request
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature for repomd_gpg_url (required for subscription-manager versions >= 1.21.10-2)
With the latest release of RHEL 7.6, subscription manager got updated and the module doesn't support the new feature (it fails at puppet run).
I appreciate if you merge the pull request as soon as possible. Please let me know if there is anything else I could do.
Thanks!