Skip to content
This repository was archived by the owner on May 21, 2019. It is now read-only.

Conversation

@glennrfisher
Copy link
Contributor

This pull request updates the text-to-speech sample app to use v0.20.0 of the Swift SDK.

@glennrfisher glennrfisher requested a review from mkistler January 23, 2018 00:38
@mkistler
Copy link

I'm curious as to why there are no changes to the xcodeproj. Don't we need to explicitly add Starscream to the build?

@glennrfisher
Copy link
Contributor Author

Not in this case, as it turns out. We still don't support WebSockets for Text to Speech—only Speech to Text. So this sample app for Text to Speech doesn't depend upon Starscream.

So why update it, then? I wanted to get the latest version in the Cartfile.resolved. We tend to suggest that everyone runs carthage update --platform iOS. But we should really be telling them to run carthage bootstrap --platform iOS for the sample apps.

(The update command will find the latest version that satisfies any version constraints in Cartfile. But the bootstrap command downloads the same version as in Cartfile.resolved.)

By suggesting bootstrap instead, we can make sure that people are using the same version of the Swift SDK and dependencies that we tested with. But it means we need to keep Cartfile.resolved up-to-date.

Copy link

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@glennrfisher glennrfisher merged commit 551dfc9 into master Jan 23, 2018
@glennrfisher glennrfisher deleted the add-starscream branch January 23, 2018 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants